src/sandbox/local.rs (1)

128-151: Add coverage for new path-selection edge cases.

Please add tests for: env var precedence, empty ZEROBUILD_SANDBOX_PATH, and relative-path rejection. This change is core behavior and currently high-impact if misconfigured.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/sandbox/local.rs` around lines 128 - 151, Add unit tests around the
sandbox path selection logic to cover env var precedence, empty
ZEROBUILD_SANDBOX_PATH, and relative-path rejection: write tests that (1) set
ZEROBUILD_SANDBOX_PATH to an absolute custom path and assert the code uses that
path as sandbox_base and successfully creates sandbox_dir (verify sandbox_dir
contains "zerobuild-sandbox-" and is under the provided path), (2) set
ZEROBUILD_SANDBOX_PATH to an empty string or remove it and assert the fallback
uses HOME/USERPROFILE (i.e., sandbox_base resolves to
~/.zerobuild/workspace/sandbox), and (3) set ZEROBUILD_SANDBOX_PATH to a
relative path and assert the creation fails (the code should return an error
when attempting to create_dir_all for a non-absolute path); use
std::env::set_var/remove_var in tests and check errors from the function that
computes sandbox_base/sandbox_dir and calls std::fs::create_dir_all to validate
behavior.

src/sandbox/local.rs (1)

152-160: Consider using the same home/workspace resolver as the config system.

Line [153]-Line [160] manually resolves home via HOME/USERPROFILE. The config layer already centralizes this logic (src/config/schema.rs:3565-3571), so reusing that resolver (or workspace_dir) would avoid path-behavior drift across modules.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/sandbox/local.rs` around lines 152 - 160, The code in
src/sandbox/local.rs manually resolves the home directory via env vars; replace
that manual logic with the centralized resolver used by the config layer (the
workspace_dir function in src/config/schema.rs) to compute the default
"~/.zerobuild/workspace/sandbox" path so behavior stays consistent; import or
call workspace_dir (or the exported resolver) where the PathBuf is built, join
"sandbox" onto the returned workspace path, and propagate or map any errors from
workspace_dir instead of re-implementing HOME/USERPROFILE resolution.

src/sandbox/local.rs (1)

681-899: Consolidate duplicated EnvGuard test helper into one shared utility

The same EnvGuard struct/Drop logic is repeated in each env-var test block. Extracting it once in the test module will reduce duplication and future drift risk.

♻️ Suggested refactor

 mod tests {
     use super::*;
     use std::sync::Mutex;
+    use std::ffi::OsString;

     static ENV_MUTEX: std::sync::Mutex<()> = std::sync::Mutex::new(());
+
+    struct EnvGuard(Option<OsString>);
+    impl Drop for EnvGuard {
+        fn drop(&mut self) {
+            match &self.0 {
+                Some(val) => std::env::set_var("ZEROBUILD_SANDBOX_PATH", val),
+                None => std::env::remove_var("ZEROBUILD_SANDBOX_PATH"),
+            }
+        }
+    }
+
+    fn guard_sandbox_env() -> EnvGuard {
+        EnvGuard(std::env::var_os("ZEROBUILD_SANDBOX_PATH"))
+    }

Then in each env-mutating test:

-        let original_env = std::env::var_os("ZEROBUILD_SANDBOX_PATH");
-        struct EnvGuard(Option<OsString>);
-        impl Drop for EnvGuard { ... }
-        let _env_guard = EnvGuard(original_env);
+        let _env_guard = guard_sandbox_env();

As per coding guidelines: "Extract shared utilities only after repeated, stable patterns appear at least three times (Rule of Three)."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/sandbox/local.rs` around lines 681 - 899, The tests duplicate the
EnvGuard struct/drop logic across multiple sandbox-path tests; extract that into
a single shared test helper to reduce duplication. Create a module-scoped or
test-module helper named EnvGuard (or rename to TestEnvGuard) and move the Drop
impl and constructor usage there, then update each test (those using ENV_MUTEX
and calling EnvGuard) to instantiate the shared helper instead of redefining the
struct; ensure visibility so LocalProcessSandboxClient tests can use it and keep
the same behavior of restoring ZEROBUILD_SANDBOX_PATH on Drop.